Skip to content

Remove warmup done twice for the same fast field in search stream #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmassot opened this issue Aug 29, 2021 · 0 comments
Closed

Remove warmup done twice for the same fast field in search stream #484

fmassot opened this issue Aug 29, 2021 · 0 comments
Assignees
@fmassot
Labels
bug Something isn't working

Comments

@fmassot
Copy link
Collaborator

fmassot commented Aug 29, 2021

When timestamp_field and fast_field_to_collect are the same, the warmup is done twice for the same field.
@fmassot fmassot added the bug Something isn't working label Aug 29, 2021
@fmassot fmassot changed the title Remove duplicate fast fields in warmup in search stream Remove warmup done twice for the same fast field in search stream Aug 29, 2021
@fmassot fmassot self-assigned this Aug 29, 2021
@fmassot fmassot mentioned this issue Aug 30, 2021
Merged
fmassot added a commit that referenced this issue Aug 31, 2021
@fmassot
Fix #483, #484 and above all handle errors happening in leaves.
1b11708
fmassot added a commit that referenced this issue Sep 1, 2021
@fmassot @guilload @fulmicoton
Fix #483, #484 and above all handle errors happening in search stream…
b76a468 
… leaves. (#487)

* Fix #483, #484 and above all handle errors happening in leaves.

* Add test on search stream with a leaf error.

* Add test on leaf search stream result.

* Add cli serve tests on a local file index.

* Fix typo in tests.

* Fix typo in test variable name.

Co-authored-by: Adrien Guillo <adrien@quickwit.io>

* Improve code syntax/readability.

* Fix fmt

Co-authored-by: Adrien Guillo <adrien@quickwit.io>
Co-authored-by: Paul Masurel <paul@quickwit.io>
@fmassot fmassot closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmassot fmassot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmassot