Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_on_abort option to VRL processing #5664

Open
cometkim opened this issue Feb 4, 2025 · 0 comments
Open

Add drop_on_abort option to VRL processing #5664

cometkim opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cometkim
Copy link

cometkim commented Feb 4, 2025

Is your feature request related to a problem? Please describe.

As reported on the Discord https://discord.com/channels/908281611840282624/915644818988863558/1335798024382971924

Quickwit always record a warn log on explicitly aborted transform with abort expression. But users may want to drop it.

Describe the solution you'd like

Originally there is drop_on_abort (default: true) option in Vector configuration.

https://vector.dev/highlights/2021-04-21-vrl-abort/

I'd like to suggest adding the same to Quickwit.

Describe alternatives you've considered

User could set RUST_LOG to such as quickwit_indexing::actors::vrl_processing=error to avoid the warning.

But it's far from ideal solution because it'll not inform user what is real problems or intentionally aborted ones.

@cometkim cometkim added the enhancement New feature or request label Feb 4, 2025
cometkim added a commit to cometkim/quickwit that referenced this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant