Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the string_or_struct logic and enables it for TermQuery. #3906

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Refactor the string_or_struct logic and enables it for TermQuery. #3906

merged 2 commits into from
Oct 3, 2023

Conversation

fulmicoton
Copy link
Contributor

Closes #3900

@fulmicoton fulmicoton force-pushed the issue/3900-term-query-struct-or-string branch from c7e1277 to ec45a0f Compare October 3, 2023 03:26
@fulmicoton fulmicoton force-pushed the issue/3900-term-query-struct-or-string branch from ec45a0f to da318ea Compare October 3, 2023 03:34
@fulmicoton fulmicoton marked this pull request as ready for review October 3, 2023 03:34
@fulmicoton fulmicoton requested a review from fmassot October 3, 2023 03:37
@fulmicoton fulmicoton mentioned this pull request Oct 3, 2023
Closed
fmassot
fmassot requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to support numbers in term query value, like {"product_id": 61809} or {"product_id": {"value": 61809}}

(could be done in a separated PR if you prefer)

@fulmicoton fulmicoton merged commit 91540c6 into main Oct 3, 2023
@fulmicoton fulmicoton deleted the issue/3900-term-query-struct-or-string branch October 3, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper handling of TERM query
2 participants
@fulmicoton @fmassot