Honor auto.offset.reset parameter in Kafka source
#4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
reviewed
Nov 7, 2023
fmassot
reviewed
Nov 7, 2023
fmassot
reviewed
Nov 7, 2023
| warn!("partition `{partition_id}` not found in assignment"); | ||
| continue; | ||
| }; | ||
| if let Err(error) = partition.set_offset(offset) { |
There was a problem hiding this comment.
shouldn't we abort if there is an error on set_offset? (just a question, I don't know which kind of error we get from this call)
fmassot
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the source ignored the
auto.offset.resetconfiguration parameter and always began consumption of a partition from the beginning. With this change, it now honors the client configuration.How was this PR tested?
Added test