Add support for OTLP HTTP API. #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All LGTM |
guilload
approved these changes
Jan 2, 2024
| vec![resource_spans] | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
It's better if these tests stay in the same file as the code under test.
| ) -> impl Filter<Extract = (impl warp::Reply,), Error = Rejection> + Clone { | ||
| require(otlp_log_service) | ||
| .and(warp::path!(String / "ingest" / "otlp" / "v1" / "logs")) | ||
| .and(warp::header::exact_ignore_case( |
There was a problem hiding this comment.
Feature request:
Support JSON over HTTP in addition to Proto.
etolbakov
reviewed
Jan 2, 2024
etolbakov
approved these changes
Jan 2, 2024
fmassot
force-pushed
the
fmassot/otlp-http
branch
from
e7cc25c to
fcde258
Compare
fmassot
force-pushed
the
fmassot/otlp-http
branch
from
042abc4 to
3c30011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the OTLP HTTP API with tracegen for traces and with an OTEL collector for logs (compression must be set to none).