Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Google Cloud Storage Implementation #4344

Merged
merged 18 commits into from
Jan 10, 2024
Merged

feat: Introduce Google Cloud Storage Implementation #4344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6698e53
feat: Introduce OpenDAL Storage Implementation
Xuanwo Jan 3, 2024
d0036d7
bump copyright
Xuanwo Jan 4, 2024
8a40e60
Merge branch 'main' into add-gcs-support
Xuanwo Jan 4, 2024
9c5daf3
feat: Add gcs support
Xuanwo Jan 8, 2024
e54a8c4
Merge remote-tracking branch 'refs/remotes/xuanwo/add-gcs-support' in…
Xuanwo Jan 8, 2024
ebdb017
Merge branch 'main' into add-gcs-support
Xuanwo Jan 8, 2024
fd2bc5b
polish
Xuanwo Jan 8, 2024
0b59c73
Nit
Xuanwo Jan 9, 2024
c02cffa
Address comments
Xuanwo Jan 9, 2024
3ed642c
Add google support in uri and config resolver
Xuanwo Jan 9, 2024
2e3e501
Fix wording
Xuanwo Jan 9, 2024
6fdd362
Add fake gcs server support
Xuanwo Jan 9, 2024
6721661
Setup integration tests for gcs
Xuanwo Jan 9, 2024
b0185f5
Update quickwit/Cargo.toml
Xuanwo Jan 9, 2024
d4449db
Update quickwit/quickwit-storage/src/opendal_storage/base.rs
Xuanwo Jan 9, 2024
1fd4fcc
Update quickwit/quickwit-storage/src/opendal_storage/google_cloud_sto…
Xuanwo Jan 9, 2024
be447f3
Polish bulk delete
Xuanwo Jan 9, 2024
7095944
Merge branch 'main' into add-gcs-support
fulmicoton Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 134 additions & 5 deletions quickwit/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions quickwit/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ num_cpus = "1"
numfmt = "1.1.1"
once_cell = "1"
oneshot = "0.1.5"
opendal = { version ="0.44", default-features = false }
etolbakov marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we feature gate this to make the development a tiny bit lighter?
(You can mimick what is done for azure.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a new feature called google. Is that what you were looking for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

openssl = { version = "0.10.60", default-features = false }
openssl-probe = "0.1.5"
opentelemetry = { version = "0.19", features = ["rt-tokio"] }
Expand Down
2 changes: 2 additions & 0 deletions quickwit/quickwit-storage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ quickwit-common = { workspace = true }
quickwit-config = { workspace = true }
quickwit-proto = { workspace = true }

opendal = { workspace = true, optional = true, features = ["services-gcs"] }

[dev-dependencies]
mockall = { workspace = true }
proptest = { workspace = true }
Expand Down
2 changes: 2 additions & 0 deletions quickwit/quickwit-storage/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ pub use self::storage::Storage;
mod bundle_storage;
mod error;
mod local_file_storage;

mod opendal_storage;
mod object_storage;
mod payload;
mod prefix_storage;
Expand Down
Loading