run migrations in a transaction #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we get an `implementation of sqlx::Acquire is not general enough` error to get arround that, we use the hidden `run_direct`, which is made specifically to go arround that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4746
we get an
implementation of sqlx::Acquire is not general enougherror. To get around that, we use the hiddenrun_direct, which is made specifically to go arround that error. See also launchbadge/sqlx#2016How was this PR tested?
created 2 dummy migrations, one valid and one invalid. Verify the 1st one doesn't get committed because the 2nd failed.