Skip to content

Conversation

Darkheir
Copy link
Contributor

@Darkheir Darkheir commented Sep 3, 2025

Description

Update tantivy to add support for regexes inside user input queries.

How was this PR tested?

Added a unit test

@Darkheir Darkheir force-pushed the feat/user_input_query_regex branch 2 times, most recently from 4de61f3 to 0c33b68 Compare September 3, 2025 09:53
@@ -1,72 +1,72 @@
[workspace]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the reformatting of this file from this PR. This is too noisy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR looks good, but it conflicts with current main. Can you update it so we can get it merged?

@Darkheir Darkheir force-pushed the feat/user_input_query_regex branch from 522a428 to d293f36 Compare October 2, 2025 07:10
@Darkheir
Copy link
Contributor Author

Darkheir commented Oct 2, 2025

your PR looks good, but it conflicts with current main. Can you update it so we can get it merged?

Thank you for the review, I just rebased my PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants