Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PyO3 0.19 #95

Closed
adamreichold opened this issue Jul 21, 2023 · 2 comments · Fixed by #98
Closed

Bump to PyO3 0.19 #95

adamreichold opened this issue Jul 21, 2023 · 2 comments · Fixed by #98

Comments

@adamreichold
Copy link
Collaborator

While Tantivy was bumped to 0.20 recently, PyO3 is still at 0.18 whereas 0.19 is current. I think it would be good to have both major dependencies at the current stable versions before making the next release. The migration guide at https://pyo3.rs/v0.19.1/migration.html?highlight=migration#from-018-to-019 contains some hints on what to look out for when making the change.

cjrh added a commit to cjrh/tantivy-py that referenced this issue Jul 21, 2023
@cjrh
Copy link
Collaborator

cjrh commented Jul 21, 2023

#98 Submitted. Fun fact 0.19.1 differs from 0.19.0 by a really bad memory leak reported by yours truly. Did we have fun in prod with that one!

@adamreichold
Copy link
Collaborator Author

I suspect that you mean PyO3/pyo3#3285 ? Note that this was present since 0.18.0 and hence this package was already affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants