Better support bytes, IPs, and JSON #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GodTamIt
force-pushed
the
extract-types
branch
from
9cc13e4
to
bafc55a
Compare
|
The CI failures are due to an ICE when building |
|
Sorry for the delay, busy week. I plan to review this weekend :) |
|
I'm also seeing the ICE locally, on rust 1.74. How annoying. |
|
This person mentions a reproducer compiling tantivy 0.21.1 in release mode: rust-lang/rust#117976 (comment) |
|
@GodTamIt You should be able to rebase your branch on top of master and have the tests run. I've pinned rust to 1.73. |
GodTamIt
force-pushed
the
extract-types
branch
from
bafc55a
to
d1d51e5
Compare
|
@cjrh Thanks for fixing the build! Looks like everything is passing and can land 🚀 |
|
Appreciate the fast turnaround on this! |
Sidhant29
pushed a commit
to Sidhant29/tantivy-py
that referenced
this pull request
Mar 12, 2024
…t-oss#152) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cameron <561860+wallies@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fills in the gaps with the aforementioned types.
Most notably:
add_bytes_field()now supports parameters around fast, indexed, and stored.add_ip_addr_field()is now available.from_dict(), either via a JSON string or aPyDict.