Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzy_term_query() documentation. #236

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

mocobeta
Copy link
Contributor

@mocobeta mocobeta commented Apr 13, 2024

This is a follow-up of #233.
I noticed my understanding of prefix parameter was wrong. Fixed the doc and added unit tests that describe fuzzy match behavior.

Copy link
Collaborator

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the test case did not really match the parameter but I did not think it too relevant to hold up the PR. Thanks for going the extra mile and extended the test cases (they are also some of the more useful forms of documentation IMHO).

@adamreichold adamreichold merged commit b857dfe into quickwit-oss:master Apr 13, 2024
10 checks passed
@mocobeta mocobeta deleted the fix-doc-fuzzy-term-query branch April 13, 2024 11:55
cjrh pushed a commit to cjrh/tantivy-py that referenced this pull request Sep 3, 2024
…it-oss#236)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants