Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(collector): src/collector readability #1399

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

ryanrussell
Copy link
Contributor

Signed-off-by: Ryan Russell git@ryanrussell.org

Signed-off-by: Ryan Russell <git@ryanrussell.org>
@codecov-commenter
Copy link

Codecov Report

Merging #1399 (56c448a) into main (8024ecf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   94.32%   94.31%   -0.02%     
==========================================
  Files         236      236              
  Lines       43577    43577              
==========================================
- Hits        41105    41100       -5     
- Misses       2472     2477       +5     
Impacted Files Coverage Δ
src/collector/tests.rs 98.18% <ø> (ø)
src/collector/top_collector.rs 97.60% <ø> (ø)
src/collector/top_score_collector.rs 96.85% <ø> (ø)
src/collector/facet_collector.rs 98.00% <100.00%> (ø)
src/fastfield/multivalued/mod.rs 94.02% <0.00%> (-2.99%) ⬇️
src/fastfield/reader.rs 89.07% <0.00%> (-0.85%) ⬇️
src/postings/stacker/expull.rs 98.57% <0.00%> (-0.48%) ⬇️
src/query/boolean_query/block_wand.rs 96.85% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8024ecf...56c448a. Read the comment docs.

src/collector/tests.rs Outdated Show resolved Hide resolved
@fulmicoton fulmicoton merged commit d750ced into quickwit-oss:main Jul 4, 2022
@fulmicoton
Copy link
Collaborator

Thanks! Make sure to run make fmt next time please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants