Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache dependencies in CI to speed up build times. #1469

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Cache dependencies in CI to speed up build times. #1469

merged 2 commits into from
Aug 23, 2022

Conversation

adamreichold
Copy link
Collaborator

I am not sure how effective this is due mixing stable and nightly within a workflow and whether it was tried before, but I have had good experiences using the rust-cache action myself.

@adamreichold
Copy link
Collaborator Author

adamreichold commented Aug 23, 2022

An unscientific experiment pushing the same commit with a different timestamp and hence hash leads to the following numbers:

job cold warm
coverage 22.5m 12m
test 13.5m 14m
test (cargo-nextest) 11m

So a significant win for the coverage job, but no improvement for the test job.

EDIT: cargo-nextest seems to help a wee bit with the test job but I am not sure whether it is worth the additional complexity (especially since the test runner does not support doctests yet).

@codecov-commenter
Copy link

Codecov Report

Merging #1469 (be2f5c1) into main (8b3a6f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   94.09%   94.09%   -0.01%     
==========================================
  Files         238      238              
  Lines       44552    44552              
==========================================
- Hits        41923    41921       -2     
- Misses       2629     2631       +2     
Impacted Files Coverage Δ
bitpacker/src/bitpacker.rs 96.03% <0.00%> (-1.00%) ⬇️
src/fastfield/reader.rs 87.73% <0.00%> (-0.62%) ⬇️
src/store/index/mod.rs 97.83% <0.00%> (-0.55%) ⬇️
src/postings/stacker/expull.rs 99.05% <0.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton
Copy link
Collaborator

@adamreichold Great win! Thank you!

@fulmicoton fulmicoton enabled auto-merge (squash) August 23, 2022 21:27
@fulmicoton fulmicoton enabled auto-merge (squash) August 23, 2022 21:27
@fulmicoton fulmicoton merged commit 2ae383e into quickwit-oss:main Aug 23, 2022
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants