Int based linear interpol #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
int-based-linear-interpol
branch
5 times, most recently
from
c3ea0ed
to
dd81978
Compare
Codecov Report
@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 93.98% 93.97% -0.02%
==========================================
Files 241 242 +1
Lines 44754 44661 -93
==========================================
- Hits 42063 41968 -95
- Misses 2691 2693 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
force-pushed
the
int-based-linear-interpol
branch
4 times, most recently
from
c7a8248
to
dd8d72b
Compare
PSeitz
force-pushed
the
int-based-linear-interpol
branch
from
dd8d72b
to
ea4d8a8
Compare
fulmicoton
force-pushed
the
main
branch
2 times, most recently
from
e550a98
to
84e0c75
Compare
fulmicoton
force-pushed
the
int-based-linear-interpol
branch
from
1a030b2
to
448d1e4
Compare
Reimplements the blockwise multilinear codec using integer arithmetics. Added comments
PSeitz
force-pushed
the
int-based-linear-interpol
branch
from
448d1e4
to
6d9f8c8
Compare
PSeitz
force-pushed
the
int-based-linear-interpol
branch
from
73b960a
to
732a8f4
Compare
fix off by one to accurately interpolate autoincrement fields
PSeitz
force-pushed
the
int-based-linear-interpol
branch
from
2c7ef49
to
0e7e892
Compare
PSeitz
reviewed
Sep 5, 2022
| impl Line { | ||
| #[inline(always)] | ||
| pub fn eval(&self, x: u64) -> u64 { | ||
| let linear_part = (x.wrapping_mul(self.slope) >> 32) as i32 as u64; |
There was a problem hiding this comment.
you want negative slopes to be interpreted as negative...
After the bitshift, you want stuff to be interpreted as negative is the 32th bit is set to 1, not the 64th.
There is probably a nicer a way to express it by expressing the slope as a i64.
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.