Truncate keys to u16::MAX in term hashmap #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -308,6 +312,8 @@ impl SharedArenaHashMap { | |||
| if self.is_saturated() { | |||
| self.resize(); | |||
| } | |||
| // Limit the key size to u16::MAX | |||
| let key = &key[..std::cmp::min(key.len(), u16::MAX as usize)]; | |||
There was a problem hiding this comment.
There is impl From<u16> for usize, i.e. the cast could be replaced by .into().
There was a problem hiding this comment.
I prefer to keep it explicit
There was a problem hiding this comment.
You can explicitly write usize::from(u16::MAX) if you prefer while still avoiding the potentially truncating cast.
There was a problem hiding this comment.
I wish rust would just coerce types that can be safely cast
here I don't think we gain much for proof reading
Truncate keys to u16::MAX, instead e.g. storing 0 bytes for keys with length u16::MAX + 1 The term hashmap has a hidden API contract to only accept terms with lenght up u16::MAX.
fulmicoton
approved these changes
Jan 11, 2024
PSeitz
added a commit
that referenced
this pull request
Apr 10, 2024
Truncate keys to u16::MAX, instead e.g. storing 0 bytes for keys with length u16::MAX + 1 The term hashmap has a hidden API contract to only accept terms with lenght up u16::MAX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate keys to u16::MAX, instead e.g. storing 0 bytes for keys with length u16::MAX + 1
The term hashmap has a hidden API contract to only accept terms with lenght up u16::MAX.