Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMTU can use PING? #192

Merged
merged 2 commits into from
Jul 10, 2023
Merged

PMTU can use PING? #192

merged 2 commits into from
Jul 10, 2023

Conversation

gorryfair
Copy link
Contributor

@gorryfair gorryfair commented May 12, 2023

fixes #190

DPLPMTUD would sometimes use ping frames. So, if I understand, a method using PING frames does not need the immediate ACK function, either one or the other is sufficient.

DPLPMTUD would sometimes use ping frames. So, if I understand,  a method using PING frames does not need the immediate ACK function, either one or the other is sufficient.
@gorryfair gorryfair changed the title Update draft-ietf-quic-ack-frequency.md PMTU can use PING? May 12, 2023
@marten-seemann
Copy link
Contributor

Acknowledgement of PING frames is not immediate, but can be delayed by up to max_ack_delay. It makes sense to use an IMMEDIATE_ACK frame, so the sender can switch to using the larger MTU as early as possible.

@gorryfair
Copy link
Contributor Author

I'm less sure, this is always a real advantage, the method would work with PING frames. I expect in most cases the important goal is to avoid black-holing traffic that has too large a size, not saving a fraction of an RTT. I think the PR should allow use with or without IMMEDIATE_ACK frame.

@mirjak
Copy link
Contributor

mirjak commented Jul 4, 2023

While potentially a PING frame could be used, it seems a bit out of scope for this document. However, maybe we should change the SHOULD to a MAY then?

@gorryfair
Copy link
Contributor Author

MAY would also work - it would alert readers to this possibly being a problem and let them decide. I'm happy for this to be resolved as you see fit.

@mirjak mirjak merged commit 36fe363 into quicwg:main Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section 8.3: DPLPMTUD can use Ping?
3 participants