Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflating credit to move window and CC #193

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Conversation

gorryfair
Copy link
Contributor

@gorryfair gorryfair commented May 12, 2023

fixes #194

Copy link
Contributor Author

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

variation in the path RTT by setting the Ack-Eliciting Threshold
to a value no larger than the current congestion window. Alternatively,
a sender can accomplish this by sending an IMMEDIATE_ACK frame once each
round trip time or after each application-limited period, although if the packet containing an IMMEDIATE_ACK is lost,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "application-limited period"? I assume you mean when transitioning from the application-limited to the cwnd-limited state?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, good point. Do we need this addition? Even in an application-limited period, you should send on ack per RTT. Why is this needed? Or do you mean idle period @gorryfair ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This could potentially be confusing as an "application period" since "period of time" could infer periodicity - English can be used in multiple ways.)

That aside, the guidance in the application-limited case ought to be to send an ACK at least once per RTT while there is data outstanding... It's a small additional tweak to request an Immediate ACK as soon as the sender transitions from being application-limited to become cwnd-limited, so that the window is released promptly, rather than delayed by upto an RTT.

Obviously (to me) that when idle, you don't request periodic ACKs....

@mirjak mirjak merged commit b62a396 into quicwg:main Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section 8.1: Avoid conflating mechanisms that do multiple things
3 participants