Remove SHOULD for 1 ACK/RTT recommendation #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is basically reverting to some old text to remove the SHOULD here. See further discussion in issue #168
ianswett
approved these changes
Jul 10, 2023
ianswett
reviewed
Jul 10, 2023
| To limit the consequences of reduced acknowledgement frequency, a sender | ||
| SHOULD cause a receiver to send an acknowledgement at least once per RTT if | ||
| there are unacknowledged ack-eliciting packets in flight. | ||
| To enable a sender to respond to potential network congestion in a timely |
There was a problem hiding this comment.
I actually don't think this is the only reason, there's also to avoid being unnecessarily CWND limited.
|
I think this is wrong, and we need to keep the SHOULD. RFC8961 (2b) also says as much about the feedback timer: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically reverting to some old text to remove the SHOULD here. See further discussion in issue #168