acknowledgments receiver is data sender #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+142
to
+143
| reducing number of packets that only contain acknowledgments also reduces | ||
| this cost at a acknowledgments receiver which is the data sender. |
There was a problem hiding this comment.
Suggested change
| reducing number of packets that only contain acknowledgments also reduces | |
| this cost at a acknowledgments receiver which is the data sender. | |
| reducing the number of acknowledgments also reduces the processing | |
| cost on the sender side. |
There was a problem hiding this comment.
I thinks this change mostly reverts my proposed change. I think the original sentence was correct, so if people think more words don't help, we don't have to accept this PR. But I thought it might clarify things. I guess it would be good if @LPardue takes a look who raised the issue.
There was a problem hiding this comment.
So after thinking some more, IMO there's a bit too much passive voice in the current document, making it hard to determine the subject and the effects. I made a new PR that makes things clearer to me at least - #271
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #224