Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables to describe each variables for out-of-order examples #279

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

tatsuhiro-t
Copy link
Contributor

This adds tables that show each variables when a packet is received for out-of-order packet examples. This would clarify what happens exactly for each packet reception and how algorithm works.

This clarifies my own comment at #248 (comment)
This might be redundant, but it would help understanding how algorithm works.

This adds tables that show each variables when a packet is received
for out-of-order packet examples.  This would clarify what happens
exactly for each packet reception and how algorithm works.
@mirjak
Copy link
Contributor

mirjak commented Mar 4, 2024

Thanks for suggesting this. I will not merge that now but if more people provide feedback and think this helps, we can still merge this later as this is purely editorial!

Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it a bit confusing to have two ways of expressing the same example, so I'd be inclined to settle on a single approach, but I don't have a strong opinion.

@tatsuhiro-t
Copy link
Contributor Author

I think the PR has an advantage over the existing way of expressing examples because it does not require additional text to explain why ACK is needed. The table is self explanatory and it contains values calculated by the presented algorithm, and it helps readers understand how it works. That said, I am fine to close this if everyone is satisfied with the current examples.

@LPardue
Copy link
Member

LPardue commented Mar 22, 2024

As a bit of an ack-frequency noobie, I prefer Tatsuhiro's table and going only with that qould work for me. Although, it's HTML rendering could use a few tweaks . I have a local change I'll create as a PR on top to show how I think we can improve things.

@ianswett ianswett merged commit 4ca50a4 into quicwg:main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants