Remaining tweaks #294
Merged
Remaining tweaks #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirjak
reviewed
Apr 23, 2024
draft-ietf-quic-ack-frequency.md
Outdated
| in the congestion window or smoothed RTT is detected that impacts the local | ||
| setting of the reordering threshold or locally-selected calculation of the | ||
| either Ack-Eliciting Threshold or the Requested Max Ack Delay. | ||
| RTT and probably even less frequently. Ideally, an ACK_FREQUENCY frame is sent only |
There was a problem hiding this comment.
Sorry for being super nit-picking here but we spend soo much time to word-smith this part that I want to be super careful. Is there a reason why you changed "likely" to "probably"? As a non-native speaker there is not much difference for me but maybe "likely" is slightly stronger? Not a big issues but wanted to double-check...
There was a problem hiding this comment.
Good point, likely is better here.
ianswett
commented
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.