Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter outputs misleading filenames #97

Closed
nekno opened this issue Jan 2, 2022 · 0 comments · Fixed by #98
Closed

Converter outputs misleading filenames #97

nekno opened this issue Jan 2, 2022 · 0 comments · Fixed by #98

Comments

@nekno
Copy link
Contributor

nekno commented Jan 2, 2022

When using convert --discard the RPU is converted to the desired format and the converter outputs a single-layer BL+RPU track, discarding the EL.

When a custom output filename isn't specified with -o, the converter always outputs a file named BL_EL.hevc by default.

Since the intended output with the --discard option is a single-layer BL+RPU track, it's confusing to see EL in the name, leaving the user to wonder if the --discard option worked.

It would be helpful and more clear if the default output conveyed its contents:

  • BL_RPU.hevc with --discard and BL_EL_RPU.hevc without, or
  • BL.hevc with --discard and BL_EL.hevc without, if you're opposed to indicating the RPU is included, as seems to be the case in other filenames
quietvoid added a commit that referenced this issue Jan 2, 2022
Change `convert` output file name depending on whether or not the EL is discarded.
Closes #97.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant