-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13/analog-quil-examples #14
Conversation
@stylewarning @ecpeterson There are some |
rfcs/analog/examples.md
Outdated
SET-FREQUENCY $qubit "ro" freq | ||
SET-SCALE $qubit "ro" scale | ||
PULSE $qubit "ro" flat(duration: duration, iq: ?) | ||
# TODO: Determine if capture_delay is needed, and how it is set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question. Is capture_delay
something that is also calibrated, or is it a fixed value that's baked into the hardware? If the latter, my uneducated instinct is to wrap it into the CAPTURE
instruction, since it's sorta part of that fixed process. If the former, a separate DELAY
is probably the right thing to do, but where you get that value from, I don't know. Perhaps that's some other sort of DEFCAL
waiting to be written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also calibrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capture delay should go away unless you specifically want to mess with it: it's baked into the channel delays in the rack now.
what's left on this? |
5ac10c4
to
35559a7
Compare
@stylewarning I addressed @caryan's |
@stylewarning this PR is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear how true-to-life / useful capture_delay.quil
will really end up being, but as an example of something that flexes the spec, I think it's good.
Add readout cavity scan example measurement in examples.md. Resolves #10.