Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13/analog-quil-examples #14

Closed
wants to merge 9 commits into from
Closed

13/analog-quil-examples #14

wants to merge 9 commits into from

Conversation

cbosborn
Copy link

Add readout cavity scan example measurement in examples.md. Resolves #10.

@cbosborn
Copy link
Author

@stylewarning @ecpeterson There are some TODOs in this PR and some open questions, hoping to start a discussion.

SET-FREQUENCY $qubit "ro" freq
SET-SCALE $qubit "ro" scale
PULSE $qubit "ro" flat(duration: duration, iq: ?)
# TODO: Determine if capture_delay is needed, and how it is set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. Is capture_delay something that is also calibrated, or is it a fixed value that's baked into the hardware? If the latter, my uneducated instinct is to wrap it into the CAPTURE instruction, since it's sorta part of that fixed process. If the former, a separate DELAY is probably the right thing to do, but where you get that value from, I don't know. Perhaps that's some other sort of DEFCAL waiting to be written.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also calibrated.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture delay should go away unless you specifically want to mess with it: it's baked into the channel delays in the rack now.

@cbosborn cbosborn requested a review from karalekas July 17, 2019 19:53
@stylewarning
Copy link
Member

what's left on this?

@cbosborn cbosborn changed the title 13/analog-quil-examples [wip] 13/analog-quil-examples Sep 17, 2019
@cbosborn
Copy link
Author

@stylewarning I addressed @caryan's DELAY removal request, and I believe he has one more question he'll post shortly. I'd also like to better understand how $-prepended variables work (e.g. $qubit) before I say this is ready. I'll remove the wip when it is.

@cbosborn cbosborn changed the title [wip] 13/analog-quil-examples 13/analog-quil-examples Sep 17, 2019
@cbosborn
Copy link
Author

@stylewarning this PR is now ready.

Copy link
Contributor

@ecpeterson ecpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear how true-to-life / useful capture_delay.quil will really end up being, but as an example of something that flexes the spec, I think it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples of Quil files
5 participants