Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: "DEFEXPI" #498
Feature: "DEFEXPI" #498
Changes from 23 commits
7a6339d
0f3e493
c08786b
f495350
6339517
b184575
cc5c4e8
f8e2df1
0e43aae
ebd1f13
f1cb6d7
88572d0
fb5062d
7b2f035
3a11de8
9b5a0f0
6ccb83c
fa33101
83b73f8
7f84746
8a75d8f
1d915ef
9cd4327
783b708
5df4c3f
78ef2ad
3fdca2c
65c85d4
aea984d
6b1a4b4
0289c7f
de27a6e
eb67698
c9f80de
f2427c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@_@
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, and I'd take suggestions as to how to name these two cases so that the functions can be split apart. The two use cases are: