fix COMPILATION-TOLERANCE slot missing error, resolves: #736 #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error processing code accessed slots of the condition using WITH-SLOTS macro and erroneously supplied slot names in the wrong package -- CL-QUIL-TESTS, not QUIL. Rewrote to access slots using full accessor forms, properly package qualified. Note that the compiler does not normally complain when WITH-SLOTS uses slot names that do not pertain to the given class. It should be a bit safer now that we're using the normal full accessors, since if these slot accessors were ever to become invalid, it would be flagged at compile time. Also added a new test for this machinery: test-%with-loose-state-prep-compression-736
stylewarning
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error processing code accessed slots of the condition using WITH-SLOTS
macro and erroneously supplied slot names in the wrong package --
CL-QUIL-TESTS, not QUIL. Rewrote to access slots using full accessor
forms, properly package qualified. Note that the compiler does not
normally complain when WITH-SLOTS uses slot names that do not pertain
to the given class. It should be a bit safer now that we're using the
normal full accessors, since if these slot accessors were ever to
become invalid, it would be flagged at compile time.
Also added a new test for this machinery:
test-%with-loose-state-prep-compression-736