Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator, Admin: UI for modifying tabulator configs #4135

Merged
merged 151 commits into from
Oct 4, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 9, 2024

  • Fix <TextEditor /> hardcoded height. Make props and look of an error similar to <M.TextField />
  • OnDirty module based on ReactProvider and RF.FormSpy to observe dirty states outside RF.Form
  • Use JSON Schema for config validation
  • Page structure:
    • Re-usable form fields are in <*Form /> components: <PrimaryForm />, ` etc.
    • Add page has a root <RF.Form> and lists all form inside. There is a simple route guard on leaving the page
    • Edit page lists all these forms wrapped with <*Card /> component each: <PrimaryCard />, <MetadataCard /> etc.
    • Card re-uses and shows Form wrapped with <RF.Form> each, also adding form buttons via StickyActions/CardActions

Edit bucket

Edit bucket

Add bucket

Add Bucket

List tables

Tabulator list

Edit/Add tables

Tabulator edit

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus
Copy link
Member Author

fiskus commented Oct 3, 2024

Errors:
Screenshot from 2024-10-03 17-30-44

@fiskus fiskus requested a review from nl0 October 3, 2024 16:15
nl0
nl0 previously approved these changes Oct 4, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is good to go now. don't forget to revert the workflow change (and wait til the registry pr is in)

@fiskus
Copy link
Member Author

fiskus commented Oct 4, 2024

Thanks!

@nl0
Copy link
Member

nl0 commented Oct 4, 2024

@fiskus how hard it would be to populate the config editor with some basic boilerplate when adding a new config? smth like:

schema:
  - name: column1 # specify the schema
    type: Utf8
source:
  type: quilt-packages
  package_name: "" # specify a RegEx for matching packages
  logical_key: ".*\\.csv$" # specify a RegEx for matching logical keys
parser:
  format: csv # or parquet

@fiskus
Copy link
Member Author

fiskus commented Oct 4, 2024

populate the config editor with some basic boilerplate

Easy, good idea


Also, I moved NameForm for renaming table to the popup::

  • It reduces frustration from row jumping from one place to another
  • it kinda re-uses UX pattern from renaming user
  • but I can't re-use the UI entirely, because list item is clickable

@fiskus fiskus requested a review from nl0 October 4, 2024 15:40
@fiskus fiskus enabled auto-merge October 4, 2024 15:51
@fiskus fiskus added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit 823aaa6 Oct 4, 2024
36 of 39 checks passed
@fiskus fiskus deleted the admin-bucket-page-long-query-config branch October 4, 2024 16:00
nl0 added a commit that referenced this pull request Oct 7, 2024
* master: (97 commits)
  Remove `<Delay />` component (#4132)
  rewrite SUMMARY (doc reorg) (#4149)
  Tabulator, Admin: UI for modifying tabulator configs (#4135)
  Bump debian from `1b0b790` to `3f9e536` in /lambdas/thumbnail (#4158)
  Bump debian from bullseye-20240904-slim to bullseye-20240926-slim in /lambdas/thumbnail (#4156)
  Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /catalog (#4151)
  Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /s3-proxy (#4152)
  Edit file / Edit with config helper (#4147)
  Fix "bad `setState()`" warning (#4150)
  Update dependency webpack to v5.94.0 [SECURITY] (#4125)
  Fix `ui.package_description` example (#4146)
  Bump urllib3 from 1.26.18 to 1.26.19 in /lambdas/s3select (#4140)
  Move bucket settings to a separate page (#4122)
  Bump debian from bullseye-20240812-slim to bullseye-20240904-slim in /lambdas/thumbnail (#4131)
  Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /catalog (#4133)
  Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /s3-proxy (#4134)
  Bump certifi from 2023.7.22 to 2024.7.4 in /lambdas/preview (#4130)
  Bump zipp from 3.15.0 to 3.19.1 in /lambdas/preview (#4129)
  Bump cryptography from 42.0.4 to 43.0.1 in /lambdas/indexer (#4128)
  Ignore line-length lint rule for CHANGELOG (#4127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants