-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulator docs #4148
Tabulator docs #4148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4148 +/- ##
========================================
Coverage 37.80% 37.80%
========================================
Files 766 766
Lines 35195 35195
Branches 4997 5190 +193
========================================
Hits 13307 13307
+ Misses 21280 20656 -624
- Partials 608 1232 +624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
we'll need to document limitations on file size (due to us reading the whole file into memory) and limit on row size (16 MB due to Athena limitations) |
probably we also should provide some price estimates |
we need to document that views don't work |
@sir-sigurd Please review and/or fix, so we can merge it tomorrow. |
Co-authored-by: Sergey Fedoseev <fedoseev.sergey@quiltdata.io>
I see it |
Actually, I now have no idea why I had ‘below’ there. Removed…
…On Thu, Oct 10, 2024 at 08:50 Sergey Fedoseev ***@***.*** ***@***.***>> wrote:
Should be fixed. Do you not see this? APIs <http://../api-reference/Admin.md#quilt3.admin.tabulator>
I see it
but I am talking about the word (below)
#4148 (comment) <#4148 (comment)>
—
Reply to this email directly, view it on GitHub <#4148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE2T43OAH2YQ3QBMT2BFLZ22O3ZAVCNFSM6AAAAABOME467CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGQ4DKNBVG4>.
You are receiving this because you were assigned.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some notes inline
Description
Suggested documentation for the proposed Tabulator feature.