Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator docs #4148

Merged
merged 35 commits into from
Oct 14, 2024
Merged

Tabulator docs #4148

merged 35 commits into from
Oct 14, 2024

Conversation

drernie
Copy link
Member

@drernie drernie commented Sep 17, 2024

Description

Suggested documentation for the proposed Tabulator feature.

@drernie drernie requested a review from nl0 September 17, 2024 19:29
@drernie drernie self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.80%. Comparing base (e0dbeba) to head (6d052f3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4148    +/-   ##
========================================
  Coverage   37.80%   37.80%            
========================================
  Files         766      766            
  Lines       35195    35195            
  Branches     4997     5190   +193     
========================================
  Hits        13307    13307            
+ Misses      21280    20656   -624     
- Partials      608     1232   +624     
Flag Coverage Δ
api-python 91.09% <ø> (ø)
catalog 12.12% <ø> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
@sir-sigurd
Copy link
Member

we'll need to document limitations on file size (due to us reading the whole file into memory) and limit on row size (16 MB due to Athena limitations)

@sir-sigurd
Copy link
Member

probably we also should provide some price estimates

@sir-sigurd
Copy link
Member

we need to document that views don't work

@drernie
Copy link
Member Author

drernie commented Oct 10, 2024

@sir-sigurd Please review and/or fix, so we can merge it tomorrow.

docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator-example.yaml Outdated Show resolved Hide resolved
drernie and others added 2 commits October 10, 2024 06:31
Co-authored-by: Sergey Fedoseev <fedoseev.sergey@quiltdata.io>
@sir-sigurd
Copy link
Member

Should be fixed. Do you not see this? APIs

I see it
but I am talking about the word (below)
#4148 (comment)

@drernie
Copy link
Member Author

drernie commented Oct 10, 2024 via email

Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some notes inline

@drernie drernie added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit cb2fc05 Oct 14, 2024
38 checks passed
@drernie drernie deleted the tabulator-docs branch October 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants