Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embed listing #4236

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix embed listing #4236

merged 4 commits into from
Nov 21, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 21, 2024

Add selection provider for embed listing and make selection optional

TODO

  • Make Selection.Provider optional. Not sure, it's worth it. It is in 24d8c20, so it's easily revertible
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.35%. Comparing base (b88874c) to head (24d8c20).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...talog/app/containers/Bucket/Selection/Provider.tsx 0.00% 7 Missing ⚠️
...p/containers/Bucket/PackageDialog/S3FilePicker.tsx 0.00% 2 Missing ⚠️
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% 2 Missing ⚠️
catalog/app/containers/Bucket/Dir.tsx 0.00% 1 Missing ⚠️
catalog/app/containers/Bucket/Listing.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4236      +/-   ##
==========================================
- Coverage   39.36%   39.35%   -0.01%     
==========================================
  Files         775      775              
  Lines       35134    35140       +6     
  Branches     5295     5296       +1     
==========================================
  Hits        13829    13829              
- Misses      20739    20745       +6     
  Partials      566      566              
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 14.70% <0.00%> (-0.01%) ⬇️
lambda 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fiskus fiskus requested a review from nl0 November 21, 2024 18:01
@nl0
Copy link
Member

nl0 commented Nov 21, 2024

(tested)

@fiskus fiskus added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 8fb0885 Nov 21, 2024
36 of 38 checks passed
@fiskus fiskus deleted the fix-embed-listing-selection branch November 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants