-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena: check access for catalog #4239
Conversation
fiskus
commented
Nov 22, 2024
•
edited
Loading
edited
- fetch each data catalog to be sure user has access to it
- fixed catalog list load, there was missing workgroup argument
- Unit tests
- Changelog entry (skip if change is not significant to end users, e.g. docs only)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4239 +/- ##
==========================================
+ Coverage 39.35% 39.40% +0.05%
==========================================
Files 775 775
Lines 35141 35163 +22
Branches 5296 5306 +10
==========================================
+ Hits 13829 13857 +28
+ Misses 20115 20109 -6
Partials 1197 1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@fiskus what about the changelog entry? |
Thanks! I forgot to push it |