Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena: check access for catalog #4239

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Athena: check access for catalog #4239

merged 4 commits into from
Nov 25, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 22, 2024

  • fetch each data catalog to be sure user has access to it
  • fixed catalog list load, there was missing workgroup argument
  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.40%. Comparing base (9ec816a) to head (afcf1ca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4239      +/-   ##
==========================================
+ Coverage   39.35%   39.40%   +0.05%     
==========================================
  Files         775      775              
  Lines       35141    35163      +22     
  Branches     5296     5306      +10     
==========================================
+ Hits        13829    13857      +28     
+ Misses      20115    20109       -6     
  Partials     1197     1197              
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 14.80% <100.00%> (+0.10%) ⬆️
lambda 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fiskus fiskus requested a review from nl0 November 25, 2024 11:25
nl0
nl0 previously approved these changes Nov 25, 2024
@fiskus fiskus added this pull request to the merge queue Nov 25, 2024
@nl0
Copy link
Member

nl0 commented Nov 25, 2024

@fiskus what about the changelog entry?

@fiskus fiskus removed this pull request from the merge queue due to a manual request Nov 25, 2024
@fiskus
Copy link
Member Author

fiskus commented Nov 25, 2024

Thanks! I forgot to push it

@fiskus fiskus requested a review from nl0 November 25, 2024 12:03
@fiskus fiskus added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit d8e208c Nov 25, 2024
38 checks passed
@fiskus fiskus deleted the athena-catalog-check-access branch November 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants