Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustls 0.20 #1150

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Upgrade to rustls 0.20 #1150

merged 4 commits into from
Oct 26, 2021

Conversation

djc
Copy link
Member

@djc djc commented Jun 22, 2021

No description provided.

djc
djc commented Jun 22, 2021
View reviewed changes
quinn-proto/src/crypto/rustls.rs Outdated Show resolved Hide resolved
Matthias247
Matthias247 reviewed Jul 2, 2021
View reviewed changes
quinn-proto/src/crypto/rustls.rs Show resolved Hide resolved
quinn-proto/src/crypto/rustls.rs Show resolved Hide resolved
quinn-proto/src/crypto/rustls.rs Show resolved Hide resolved
quinn-proto/src/crypto/rustls.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the rustls-0.20 branch 7 times, most recently from 6a201c4 to 5293a12 Compare July 7, 2021 18:16
Matthias247
Matthias247 reviewed Jul 7, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
interop/src/main.rs Outdated Show resolved Hide resolved
perf/src/bin/perf_client.rs Show resolved Hide resolved
quinn-proto/src/crypto/rustls.rs Show resolved Hide resolved
@djc djc marked this pull request as draft July 8, 2021 08:18
Ralith
Ralith reviewed Aug 1, 2021
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the reduced magic around configuration!

quinn-proto/src/crypto/types.rs Outdated Show resolved Hide resolved
quinn-proto/src/crypto/rustls.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the rustls-0.20 branch 2 times, most recently from f154d22 to f8ff943 Compare August 2, 2021 13:07
@djc
Copy link
Member Author

djc commented Aug 2, 2021

Test failure is due to hawkw/sharded-slab#60.

@djc djc mentioned this pull request Sep 27, 2021
Merged
This was referenced Sep 30, 2021
Closed
Closed
@Ralith Ralith mentioned this pull request Oct 16, 2021
Merged
@djc djc force-pushed the rustls-0.20 branch 2 times, most recently from 23be2eb to a930a07 Compare October 25, 2021 09:08
@djc djc marked this pull request as ready for review October 25, 2021 09:08
@djc
Copy link
Member Author

djc commented Oct 25, 2021

I think this is ready now!

@djc djc mentioned this pull request Oct 25, 2021
Closed
Ralith
Ralith previously approved these changes Oct 25, 2021
View reviewed changes
perf/Cargo.toml Outdated Show resolved Hide resolved
quinn-proto/Cargo.toml Outdated Show resolved Hide resolved
djc added 3 commits October 26, 2021 10:58
@djc
Upgrade to rustls 0.20
c7993e4
@djc
Remove now unnecessary QUIC_CIPHER_SUITES
d335810
@djc
Disable default features for rustls
e9f20f4 
In rustls 0.20, TLS 1.2 is optional but enabled by default. We also
don't need to depend on rustls enabling logging.
@Ralith Ralith merged commit 78dc236 into main Oct 26, 2021
@Ralith Ralith deleted the rustls-0.20 branch October 26, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthias247 Matthias247 Matthias247 left review comments

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @Ralith @Matthias247