-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract udp crate #1180
Extract udp crate #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this generally LGTM. Sorry for the long review turnaround!
I appreciate the logically isolated commits; they make it a lot easier to scan things. Would you mind squashing the first two together so that there's not an unbuildable state between them?
4953932
to
c93533e
Compare
Done. I also rebased onto main. |
Thanks! |
This one is easy - moved code from quinn/platform into quinn-udp subcrate.
I will try to apply the code from https://github.com/ipfs-rust/udp-socket (which is runtime-agnostic due to use of
async-io
instead oftokio
) in the next PR.Fix #1178