Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract udp crate #1180

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Extract udp crate #1180

merged 3 commits into from
Sep 21, 2021

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Aug 19, 2021

This one is easy - moved code from quinn/platform into quinn-udp subcrate.
I will try to apply the code from https://github.com/ipfs-rust/udp-socket (which is runtime-agnostic due to use of async-io instead of tokio) in the next PR.

Fix #1178

@kpp kpp marked this pull request as ready for review August 19, 2021 12:27
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments.

quinn-udp/Cargo.toml Outdated Show resolved Hide resolved
quinn-udp/Cargo.toml Show resolved Hide resolved
Ralith
Ralith previously requested changes Sep 19, 2021
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this generally LGTM. Sorry for the long review turnaround!

I appreciate the logically isolated commits; they make it a lot easier to scan things. Would you mind squashing the first two together so that there's not an unbuildable state between them?

quinn-udp/Cargo.toml Show resolved Hide resolved
@kpp
Copy link
Contributor Author

kpp commented Sep 21, 2021

Done. I also rebased onto main.

@djc djc merged commit 8c27e64 into quinn-rs:main Sep 21, 2021
@djc
Copy link
Member

djc commented Sep 21, 2021

Thanks!

@kpp kpp deleted the extract_udp_crate branch September 21, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract udp socket handling into a separate crate
3 participants