Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace structopt with its successor, clap 3 #1287

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Replace structopt with its successor, clap 3 #1287

merged 1 commit into from
Jul 3, 2022

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 22, 2022

Only affects examples/tools.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 22, 2022

Looks like this is blocked on updating MSRV to 1.54.

@djc
Copy link
Member

djc commented Jan 22, 2022

See clap-rs/clap#3267.

KirillLykov
KirillLykov reviewed May 27, 2022
View reviewed changes
bench/Cargo.toml Outdated Show resolved Hide resolved
@Ralith
Copy link
Collaborator Author

Ralith commented Jul 3, 2022

This should be mergeable now that we've bumped MSRV.

@djc djc merged commit fe93a68 into main Jul 3, 2022
@djc djc deleted the clap branch July 3, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirillLykov KirillLykov KirillLykov left review comments

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ralith @djc @KirillLykov