Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump versions to 0.9.4 #1605

Merged
merged 2 commits into from
Jul 21, 2023
Merged

bump versions to 0.9.4 #1605

merged 2 commits into from
Jul 21, 2023

Conversation

lijunwangs
Copy link
Contributor

bum quinn and quinn-proto version to 0.9.4

@lijunwangs
Copy link
Contributor Author

Request to bump the version to 0.9.4 in 0.9.x release line. cc @djc @Ralith

@djc
Copy link
Member

djc commented Jul 19, 2023

I suppose -proto should go to 0.9.3 instead?

Ralith
Ralith requested changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the quinn changes rely on a new quinn-proto API, the dependency of quinn on quinn-proto must require the new version.

@lijunwangs
Copy link
Contributor Author

I suppose -proto should go to 0.9.3 instead?

I think somehow we have already have 0.9.3 for quinn-proto? https://docs.rs/quinn-proto/0.9.3/quinn_proto/index.html

@lijunwangs
Copy link
Contributor Author

Because the quinn changes rely on a new quinn-proto API, the dependency of quinn on quinn-proto must require the new version.

Updated dependency

lijunwangs
lijunwangs commented Jul 20, 2023
View reviewed changes
Copy link
Contributor Author

@lijunwangs lijunwangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lint check errors are unrelated to this PR.

@lijunwangs
Copy link
Contributor Author

@djc @Ralith can you help merge this and release 0.9.4? Thanks!!

Ralith
Ralith approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Ralith Ralith merged commit e07003e into quinn-rs:0.9.x Jul 21, 2023
2 of 8 checks passed
@Ralith
Copy link
Collaborator

Ralith commented Jul 21, 2023

Published as 0.9.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lijunwangs @djc @Ralith