-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running perf client and server within dockers #1659
Draft
stormshield-damiend
wants to merge
3
commits into
quinn-rs:main
Choose a base branch
from
stormshield-damiend:perf_docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Allow running perf client and server within dockers #1659
stormshield-damiend
wants to merge
3
commits into
quinn-rs:main
from
stormshield-damiend:perf_docker
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add set -eu
to the shell scripts for robustness?
stormshield-damiend
force-pushed
the
perf_docker
branch
from
September 12, 2023 07:19
51e8098
to
c2c124e
Compare
This gets further now, but still fails before doing any testing:
|
i will rebase the work as it is quite old and see if i also have the issue. |
stormshield-damiend
force-pushed
the
perf_docker
branch
from
January 12, 2024 09:32
c2c124e
to
43318fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to run perf_client and perf_server within two dockers with optional simulated latency.
To build the binaries and the docker, use :
build.sh
To launch the server, use :
./run-server.sh -l 10 -c -o
This will :
To launch the client, use :
./run-client.sh -l 10
This will launch perf_client for 5sec with a simulated latency of 10ms (we will the have a RTT of 10ms).
/!\ For now the GSO is disabled otherwise wireshark is not capable of deciphering packets.