fix(udp): feature flag tracing in windows.rs

[mxinden]

8712910 made tracing optional and added optional log, but forgot to update quinn-udp/src/windows.rs. This commit fixes the oversight and bumps the quinn-udp version to v0.5.4.

---

Discovered in mozilla/neqo#2002.

I assume that this is not an issue for most quinn users as they don't run quinn-udp with default-features = false".

I am sorry for the oversight. I can look into a GitHub CI workflow that prevents this in the future tomorrow.

[mxinden]

Not sure what your policy towards cargo yank is, but this might be a good candidate.

Again, sorry for the trouble.

[mxinden]

🤦 another mistake. Too late in the evening for me. Will push a commit in a minute.

[mxinden]

Alright, this should be it. For the record, compiling with all feature combinations:

➜  src git:(optional-tracing-windows) ✗ cargo check --no-default-features --target x86_64-pc-windows-msvc
warning: /home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp/Cargo.toml: unused manifest key: target.cfg(any(target_os = "linux", target_os = "windows")).bench
    Checking quinn-udp v0.5.4 (/home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s
➜  src git:(optional-tracing-windows) ✗ cargo check --no-default-features --target x86_64-pc-windows-msvc --features tracing
warning: /home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp/Cargo.toml: unused manifest key: target.cfg(any(target_os = "linux", target_os = "windows")).bench
    Checking tracing v0.1.40
    Checking quinn-udp v0.5.4 (/home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s
➜  src git:(optional-tracing-windows) ✗ cargo check --no-default-features --target x86_64-pc-windows-msvc --features direct-log
warning: /home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp/Cargo.toml: unused manifest key: target.cfg(any(target_os = "linux", target_os = "windows")).bench
    Checking quinn-udp v0.5.4 (/home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s
➜  src git:(optional-tracing-windows) ✗ cargo check --no-default-features --target x86_64-pc-windows-msvc --features tracing,direct-log
warning: /home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp/Cargo.toml: unused manifest key: target.cfg(any(target_os = "linux", target_os = "windows")).bench
    Checking quinn-udp v0.5.4 (/home/mxinden/code/github.com/quinn-rs/quinn/quinn-udp)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.30s

[Ralith]

Good catch, thanks! No worries about the error, it happens.

A good follow-up item might be to avoid the fragile and verbose duplicate conditionals by introducing some internal facade macros that dispatch to tracing or log or nothing as appropriate.

[Ralith]

Published.

[djc]

That sounds good to me. rustls has something like this which we can probably just copy over.

[mxinden]

A good follow-up item might be to avoid the fragile and verbose duplicate conditionals by introducing some internal facade macros that dispatch to tracing or log or nothing as appropriate.

That sounds good to me. rustls has something like this which we can probably just copy over.

Looking into this now.