Revert "Implement fallback for sendmmsg and recvmmsg"
#1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
force-pushed
the
libc-recvmmsg-directly
branch
from
026adea
to
b1fc3b2
Compare
mxinden
commented
Aug 14, 2024
mxinden
force-pushed
the
libc-recvmmsg-directly
branch
from
e8934b7
to
7680e38
Compare
|
Friendly ping @Ralith. Do you have some time to take a look? |
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In quinn-rs#1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
mxinden
force-pushed
the
libc-recvmmsg-directly
branch
from
bf31877
to
fb44c77
Compare
|
Thank you for the review! I am fine with no longer supporting both:
(1) allows us to drop indirection I updated this pull request accordingly. @Ralith would you mind taking another look? |
Ralith
approved these changes
Sep 2, 2024
|
|
Thank you @djc for the prompt release. Very much appreciated 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e6f1844.
e6f1844 called
sendmmsgandrecvmmsgthroughlibc::syscallinstead oflibc::sendmmsgandlibc::recvmmsg, thus preventing linking issues on old Android systems wherelibc::sendmmsgandlibc::recvmmsgisn't available.In #1503 (comment) the suggestion was made to no longer support these old Android systems (API level 16).
This commit reverts e6f1844. Given that
sendmmsgsupport was previously dropped in ee08826, only therecvmmsgcalls are reverted.Alternative to #1964. Given the additional simplicity, my preference is for this change.