Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand ECN support #222

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Expand ECN support #222

merged 2 commits into from
Feb 28, 2019

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Feb 2, 2019

libc's CMSG macros got built out to many more platforms. There may remain some obscure platforms where this will still fail to build, but we can account for them as they show up in practice.

Note that some bugs remain in the new libc bindings, so we may want to defer merging this until rust-lang/libc#1235 shows up in a release.

djc
djc previously approved these changes Feb 2, 2019
@djc
Copy link
Member

djc commented Feb 2, 2019

Yeah, waiting for the next release sounds like a good idea.

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #222 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   74.82%   74.84%   +0.01%     
==========================================
  Files          24       24              
  Lines        6150     6150              
==========================================
+ Hits         4602     4603       +1     
+ Misses       1548     1547       -1
Impacted Files Coverage Δ
quinn/src/platform/unix.rs 65.04% <ø> (ø)
quinn-proto/src/packet.rs 81.22% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bc288...b0510d9. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@92deb61). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #222   +/-   ##
=========================================
  Coverage          ?   74.82%           
=========================================
  Files             ?       24           
  Lines             ?     6150           
  Branches          ?        0           
=========================================
  Hits              ?     4602           
  Misses            ?     1548           
  Partials          ?        0
Impacted Files Coverage Δ
quinn/src/platform/unix.rs 65.04% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92deb61...70e97d7. Read the comment docs.

@Ralith Ralith force-pushed the more-ecn branch 7 times, most recently from 65579eb to 2d3e596 Compare February 27, 2019 21:59
libc's CMSG macros got built out to many more platforms. There may
remain some obscure platforms where this will still fail to build, but
we can account for them as they show up in practice.
@Ralith
Copy link
Collaborator Author

Ralith commented Feb 28, 2019

I think this is ready for re-review and merge. If the macos inconsistencies are representative, there'll probably be additional tweaks necessary for other platforms, but only minor ones, and their necessity will be immediately obvious when socket configuration fails.

@djc djc merged commit 7da5188 into master Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the more-ecn branch February 28, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants