Allow to use the incoming IP address for sending outgoing packets #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jan 4, 2021
Ralith
reviewed
Jan 4, 2021
Ralith
reviewed
Jan 4, 2021
djc
reviewed
Jan 5, 2021
djc
force-pushed
the
src
branch
2 times, most recently
from
5e6909c to
67cf59b
Compare
Matthias247
commented
Jan 6, 2021
Matthias247
commented
Jan 6, 2021
| @@ -273,7 +273,7 @@ pub fn caps() -> UdpCapabilities { | |||
| *CAPABILITIES | |||
| } | |||
|
|
|||
| const CMSG_LEN: usize = 64; | |||
| const CMSG_LEN: usize = 80; | |||
There was a problem hiding this comment.
This was updated to account for GSO + src-ip setting
This is a follow-up for quinn-rs#943. When a socket is bound to a wildcard IP address, sending the outgoing IP might use a different source IP address than the one the packet was received on, since the OS might not be able to identify the necessary route. This would lead packets not allowing to reach the client. This change adds a setting which will set an explicit source address in all outgoing packets. The source address which will be used is the local IP address which was used to receive the initial incoming packet.
djc
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #943. When a socket is bound to a wildcard
IP address, sending the outgoing IP might use a different source IP
address than the one the packet was received on, since the OS might
not be able to identify the necessary route. This would lead packets
not allowing to reach the client.
This change adds a setting which will set an explicit source address
in all outgoing packets. The source address which will be used is
the local IP address which was used to receive the initial incoming
packet.