Socket address decoding issue repro for #968 #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change shows that socket addresses are not properly decoded once the address is zero-initialized and not non-initialized. Log entries show: ``` Jan 14 19:06:05.373 TRACE quinn::platform::imp: Sending datagram to [::ffff:127.0.0.1]:46146 Jan 14 19:06:05.373 TRACE quinn::platform::imp: Received datagram from 115.127.0.0:56707 Jan 14 19:06:05.376 TRACE quinn::platform::imp: Sending datagram to 115.127.0.0:56707 ``` I think the addresses are somehow shifted by 1 byte, but don't fully understand how this didn't happen before with non-initialized buffers.
|
Now that we have #987, I don't think we need this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change shows that socket addresses are not properly decoded
once the address is zero-initialized and not non-initialized.
Log entries show:
I think the addresses are somehow shifted by 1 byte, but don't fully
understand how this didn't happen before with non-initialized buffers.