Carbon modelling improvements #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2025
kndehaan
force-pushed
the
carbon-modelling
branch
from
244d11f to
653bf94
Compare
mabijkerk
reviewed
Oct 8, 2025
Comment on lines
+626
to
+629
| 'demand * loss_output_conversion / BILLIONS' => { | ||
| label: 'Annual fuel production', | ||
| key: :annual_fuel_production, | ||
| unit: 'PJ / year' |
There was a problem hiding this comment.
Nice to have is to add the production per output carrier as a collapsable list here.
noracato
requested changes
Oct 9, 2025
noracato
approved these changes
Oct 9, 2025
* Chemicals and synthetic products migration for carbon modelling * Update to separate rename and remove methods * Extract the correct values out of dataset.json and access them correctly in the migration * Schema changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improved carbon modelling to the ETM. Changes include:
Goes with: