Skip to content

Conversation

louispt1
Copy link
Contributor

@louispt1 louispt1 commented Oct 6, 2025

Removing outdated attributes.

@kaskranenburgQ I removed a couple more attributes as well and rebased. I think the only outstanding issues are Uden and Zeeland, but I assume we can just re-export those? Interested to hear your thoughts

@kaskranenburgQ
Copy link
Contributor

Both Uden and Zeeland are retired datasets, we can just remove them from this branch. Bit strange that they are on here.

Copy link
Contributor

@kaskranenburgQ kaskranenburgQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some changes I would not expect for nl, and nl2023.
We should check these.

Copy link
Contributor

@kaskranenburgQ kaskranenburgQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check where these changes are coming from

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should not be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because if we save the datasets via Atlas and they do not have an attribute, it will be automagically added with a default value (in this case has_coastline = true). That is the reason for a majority of these changes.

If we don't want these datasets to take those default values, we have to set the values explicitly in ETLocal and re-export or set the parent_id correctly so the dataset inherits the correct attribute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check these changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is fine, keep it in mind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition is fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition is fine.

@louispt1 louispt1 merged commit c7f96a7 into master Oct 9, 2025
1 check passed
@louispt1 louispt1 deleted the derived-datasets branch October 9, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants