Enabled editing the title of a collection via Stimulus #96
Conversation
| def update | ||
| @collection = Collection.find(params[:id]) | ||
|
|
||
| if @collection.update(create_collection_params) |
There was a problem hiding this comment.
| if @collection.update(create_collection_params) | |
| if @collection.update(update_collection_params) |
Let's make sure a user can't accidentally update the version, or scenarios when the update form does not yet contain them. We'd need something like update_collection_params.
| @@ -54,6 +54,16 @@ def new | |||
| end | |||
| end | |||
|
|
|||
| def update | |||
| @collection = Collection.find(params[:id]) | |||
There was a problem hiding this comment.
| @collection = Collection.find(params[:id]) |
We should check authentication and not just do a find_by. If you add update to the hook load_and_authorize_resource, @collection will become available and will be validated already.
app/views/collections/show.html.erb
Outdated
| @@ -1,4 +1,12 @@ | |||
| <%- content_for :menu_title, @collection.title %> | |||
| <%- content_for :menu_title do %> | |||
| <span contenteditable="true" | |||
There was a problem hiding this comment.
Is it always editable for everybody?
There was a problem hiding this comment.
Good point! After I add update to the load_and_authorize_resource, will this work/ is this the right approach?
<span contenteditable="<%= can?(:update, @collection) %>"
There was a problem hiding this comment.
Currently the collection is in the show action, not in the update one :) But I assume this would work.
However, as a rule we try to put the least logic in the view as possible. The more "complicated" the logic is, the more we want to put it in the controller or a component helper to keep our views clean, and have a clear idea from looking at the controller what is going on. The can? method is mostly used in before hooks of the controller, so we can classify it as something out of the league of a view.
One possibility for instance could be to create a boolean @editable = can?(:update, @collection) in the show action, and reference it in the view.
There was a problem hiding this comment.
Or, since a Collection has only one user attached: @collection.user == current_user. Whichever you prefer.
There was a problem hiding this comment.
Thanks! I will have a go refactoring it in this way
I struggled to make the title appear editable on hover without it becoming very ugly - now it gets underlined.