feat(MLOP-1985): optional params #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellyrds
approved these changes
Nov 9, 2023
butterfree/extract/source.py
Outdated
| """ | ||
|
|
||
| def __init__(self, readers: List[Reader], query: str) -> None: | ||
| def __init__( | ||
| self, readers: List[Reader], query: str = "", eager_evaluation: bool = True, |
There was a problem hiding this comment.
why did you add this empty string as default value?
albjoaov
reviewed
Nov 9, 2023
butterfree/extract/source.py
Outdated
| """ | ||
|
|
||
| def __init__(self, readers: List[Reader], query: str) -> None: | ||
| def __init__( | ||
| self, readers: List[Reader], query: str = "", eager_evaluation: bool = True, |
butterfree/extract/source.py
Outdated
| """ | ||
|
|
||
| def __init__(self, readers: List[Reader], query: str) -> None: | ||
| def __init__( | ||
| self, readers: List[Reader], query: str = "", eager_evaluation: bool = True, |
There was a problem hiding this comment.
By the docs, we have: "Lazy evaluation can improve Spark's performance as it allows Spark to build the best version of the execution plan.". Looks like that False as default is better, or am I wrong?
There was a problem hiding this comment.
Or is it True to maintain some compatibility?
There was a problem hiding this comment.
You're right, it's defaulted True so we can turn it off gradually in our pipelines.
albjoaov
approved these changes
Nov 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
michellyrds
approved these changes
Nov 10, 2023
ralphrass
added a commit
that referenced
this pull request
Nov 14, 2023
* feat(MLOP-1985): optional params (#347) ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? 📖
The
eager_evaluationparam forces Spark to apply the currently mapped changes to a DataFrame. When this parameter is set to False, Spark follows its standard behavior of lazy evaluation. Lazy evaluation can improve Spark's performance as it allows Spark to build the best version of the execution plan.The
row_deduplicationis not applicable to all scenarios. For instance, when using Delta operations, row deduplication can be done throughmergeoperations.What? 🔧
Type of change
Please delete options that are not relevant.
How everything was tested? 📏