Upgraded webpack-config to support Webpack v4 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nzapponi rebase? We need to see this through. |
|
Looping back to this - I'd like to use this as a starting point for modernizing this repo. @nzapponi can you rebase when you get a chance? Alternatively I'll integrate in a separate PR if you're occupied! |
Merged
|
@jesseditson I haven't looked at this in a while, I'd recommend integrating it into another PR and testing the work again before pulling! |
|
Closed via #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elsigh here is the upgraded Webpack config to support v4 and the latest updates.
I replaced a bunch of plugins and rewrote parts of webpack.config.js to support the newer version.
I also modified the config to minify CSS too, reducing the file size in production builds (approx. 20% smaller).
Overall, Uglify does a better job as well, making the js bundle smaller.
In total, I noticed a reduction in the overall app.ele bundle file size of approx 15-25%.
Side effects of this update are also the fixing of issue #30 and the clearing of all vulnerabilities that npm used to identify on Quip Live Apps.
I have tested it on three live apps and it worked fine, could you test it out as well?
Thanks!