Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GaugeDelta event Stats() should not send an absolute value of 0. #23

Closed
mmb opened this issue Jun 10, 2015 · 2 comments
Closed

GaugeDelta event Stats() should not send an absolute value of 0. #23

mmb opened this issue Jun 10, 2015 · 2 comments

Comments

@mmb
Copy link

mmb commented Jun 10, 2015

It appears to be copied from the Gauge event, which does not look like the correct logic for GaugeDelta.
@quipo
Copy link
Owner

quipo commented Jan 18, 2016

hey Matthew, should I simply delete this line? https://github.com/quipo/statsd/blob/master/event/gaugedelta.go#L34

@mmb
Copy link
Author

mmb commented Jan 19, 2016

Yes I think that's the correct fix.

If the delta value is negative, it can be sent as is.

If the delta value is positive it needs to have the '+' added or it will set the value of the gauge instead of applying a delta.

quipo added a commit that referenced this issue Aug 1, 2017
@quipo
issue #23: GaugeDelta event should not send an absolute value of 0; c…
d39016b 
…ompile-time assertion to verify default events implement the Event interface; added tests
@quipo quipo closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmb @quipo