Skip to content

Commit

Permalink
oopsy: fix Aloalo tornado mistake (#6015)
Browse files Browse the repository at this point in the history
  • Loading branch information
quisquous authored Dec 15, 2023
1 parent 5034217 commit 369704f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import ZoneId from '../../../../../resources/zone_id';
import { OopsyData } from '../../../../../types/data';
import { OopsyMistakeType, OopsyTrigger, OopsyTriggerSet } from '../../../../../types/oopsy';
import { LocaleText } from '../../../../../types/trigger';
import { playerDamageFields } from '../../../oopsy_common';
import { playerDamageFields, playerTargetFields } from '../../../oopsy_common';

// TODO: people who missed their 8AE2 Burst tower
// TODO: failing 8BEB Radiance orb damage during Analysis
Expand All @@ -29,8 +29,7 @@ const renameMistake = (
return {
id: triggerId,
type: 'Ability',
netRegex: NetRegexes.ability({ id: abilityId, ...playerDamageFields }),
condition: (data, matches) => data.DamageFromMatches(matches) > 0,
netRegex: NetRegexes.ability({ id: abilityId, ...playerTargetFields }),
mistake: (_data, matches) => {
return {
type: type,
Expand Down
5 changes: 2 additions & 3 deletions ui/oopsyraidsy/data/06-ew/dungeon/another_aloalo_island.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import ZoneId from '../../../../../resources/zone_id';
import { OopsyData } from '../../../../../types/data';
import { OopsyMistakeType, OopsyTrigger, OopsyTriggerSet } from '../../../../../types/oopsy';
import { LocaleText } from '../../../../../types/trigger';
import { playerDamageFields } from '../../../oopsy_common';
import { playerDamageFields, playerTargetFields } from '../../../oopsy_common';

// TODO: people who missed their 8AC2 Burst tower
// TODO: failing 8894 Radiance orb damage during Analysis
Expand All @@ -24,8 +24,7 @@ const renameMistake = (
return {
id: triggerId,
type: 'Ability',
netRegex: NetRegexes.ability({ id: abilityId, ...playerDamageFields }),
condition: (data, matches) => data.DamageFromMatches(matches) > 0,
netRegex: NetRegexes.ability({ id: abilityId, ...playerTargetFields }),
mistake: (_data, matches) => {
return {
type: type,
Expand Down
2 changes: 1 addition & 1 deletion ui/oopsyraidsy/oopsy_common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const damageFields = {
};

export const playerTargetFields = {
targetId: '[^4].......',
targetId: '1.......',
};

export const playerDamageFields = {
Expand Down

0 comments on commit 369704f

Please sign in to comment.