-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace zoneRegex with zoneID #1037
Labels
Comments
Copying from #1528:
|
This was referenced Jul 28, 2020
Merged
quisquous
added a commit
that referenced
this issue
Jul 31, 2020
This is the "switch to the new event type" part of #1037, where followups can start using the zone id more.
quisquous
added a commit
that referenced
this issue
Aug 1, 2020
This is the "switch to the new event type" part of #1037, where followups can start using the zone id more.
quisquous
added a commit
that referenced
this issue
Aug 8, 2020
Other than user triggers, this finishes off #1037.
quisquous
added a commit
that referenced
this issue
Aug 23, 2020
Other than user triggers, this finishes off #1037.
quisquous
added a commit
that referenced
this issue
Aug 23, 2020
Other than user triggers, this finishes off #1037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OverlayPlugin has a ChangeZone event that returns the ID, but no zone name string. (Alternatively it could listen to the ZoneChangeDelegate from the ACT plugin instead of parsing the network log, which gives both the id and the zone name string).
It would be nice to hook cactbot up to something that returns both the zoneid and the regex and slowly switch over raidboss and oopsyraidsy to use zone ids. I think it would be good to support both zoneID and zoneRegex until everything is swapped over, and then zoneRegex can be removed.
This would help remove translation needs for all zone names (especially if Ravahn ever decides to change whether zone names are translated) and will help with the start of a patch when the zone names are sometimes unknown.
The text was updated successfully, but these errors were encountered: