Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace zoneRegex with zoneID #1037

Closed
quisquous opened this issue Feb 11, 2020 · 1 comment
Closed

Replace zoneRegex with zoneID #1037

quisquous opened this issue Feb 11, 2020 · 1 comment

Comments

@quisquous
Copy link
Owner

quisquous commented Feb 11, 2020

OverlayPlugin has a ChangeZone event that returns the ID, but no zone name string. (Alternatively it could listen to the ZoneChangeDelegate from the ACT plugin instead of parsing the network log, which gives both the id and the zone name string).

It would be nice to hook cactbot up to something that returns both the zoneid and the regex and slowly switch over raidboss and oopsyraidsy to use zone ids. I think it would be good to support both zoneID and zoneRegex until everything is swapped over, and then zoneRegex can be removed.

This would help remove translation needs for all zone names (especially if Ravahn ever decides to change whether zone names are translated) and will help with the start of a patch when the zone names are sometimes unknown.

@quisquous
Copy link
Owner Author

quisquous commented Jul 26, 2020

Copying from #1528:

  • land this
  • get Add zoneName to ChangeZone event ngld/OverlayPlugin#138 merged
  • wait for OverlayPlugin release
  • switch to using the new event type
  • add code in raidboss/oopsy to support zoneId
  • add documentation
  • switch raidboss/oopsy over to using zoneId
  • switch various other bits of code using zone names (e.g. lang)
  • remove use of zoneRegex from cactbot files (but don't remove support)

quisquous added a commit that referenced this issue Jul 31, 2020
This is the "switch to the new event type" part of #1037, where
followups can start using the zone id more.
quisquous added a commit that referenced this issue Aug 1, 2020
This is the "switch to the new event type" part of #1037, where
followups can start using the zone id more.
quisquous added a commit that referenced this issue Aug 1, 2020
quisquous added a commit that referenced this issue Aug 8, 2020
Other than user triggers, this finishes off #1037.
quisquous added a commit that referenced this issue Aug 23, 2020
Other than user triggers, this finishes off #1037.
quisquous added a commit that referenced this issue Aug 23, 2020
Other than user triggers, this finishes off #1037.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant