-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Anonymizer removes some fields from 38-lines #5842
Labels
Comments
At the top of the file (let me know if this needs more explanation): // Fields at this index and beyond are cleared, when anonymizing.
firstUnknownField?: number; And yeah, I think that seems reasonable to move it to 18 if 19-21 can contain ids. |
quisquous
pushed a commit
that referenced
this issue
Oct 7, 2023
See #5842 While field 20 is technically the first field that could contain a player ID, truncating right there results in an incomplete triplet. Better to just delete the entirety of the first triplet instead of having a malformed line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When I use the log splitter with the 'anonymize' feature enabled, 38-lines have some fields removed.
Without 'anonymize log' (anonymized by hand):
38|2023-10-06T21:10:15.2640000-07:00|1234ABCD|Player Name|005A5A1E|90282|90282|10000|10000|11||100.88|108.01|0.00|-2.95|0|0|0|29640030|4484BB3A|1234ABCD|0A0168|41F00000|E0000000|14016A|41F00000|E0000000|01FB|C1A00000|1234ABCD|0763|41C71056|1001AAAA|0A31|41D65E2E|1002BBBB|278de10f0e5fbd59
With 'anonymize log':
38|2023-10-06T21:10:15.2640000-07:00|10FF0003|Dodoqosu Neneqosu|005A5A1E|90282|90282|10000|10000|11||100.88|108.01|0.00|-2.95|0|0|0|29640030|4484BB3A|||||||||||||||||
If it's more effort to fully parse the 38-line to anonymize it fully, then I think the next most reasonable thing would be to truncate it two fields earlier. As it stands, it has a partial triplet of "|29640030|4484BB3A||", where the source entity ID of the buff should be in the empty field. The fields of each triplet are |<params, usually stack count>||
I'm not exactly sure what the netlog defs values mean, but I think it might just be a case of changing
firstUnknownField
from 20 to 18?The text was updated successfully, but these errors were encountered: