Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: The smallest of additions to en.js #1207

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Resources: The smallest of additions to en.js #1207

merged 2 commits into from
Mar 18, 2020

Conversation

JLGarber
Copy link
Collaborator

No description provided.

@quisquous
Copy link
Owner

Could you add this effect to all languages? Oopsy behaves badly when something is undefined.

@JLGarber
Copy link
Collaborator Author

Oops! I remembered that it had made its way to DE/FR/JA and didn't even think to check the others.

@quisquous quisquous merged commit b78ab89 into quisquous:master Mar 18, 2020
@quisquous
Copy link
Owner

I really need to add some tests for this or rearrange how it works entirely. I think the effects spread over multiple files is not really working (or matches the rest of the code).

@JLGarber
Copy link
Collaborator Author

It's definitely less comfortable compared to having a single language config file, although I can certainly understand why it was originally set up this way.

That being said, a thing we could do that would require less restructuring is to place a "master elements object" into the EN language file. Something like:

masterObject: {
  actionsToTranslate: {
    Action1: 'ID1',
    Action2: 'ID2',
    // ETC
  },
  statusesToTranslate: {
    Status1: 'ID1',
    Status2: 'ID2',
    // ETC
  },
  // ETC
}

So we would just add new items to be translated in one place, and then script something to iterate over the object, find the ID on XIVAPI/Wakingsands/Coinach CSV dumps, and update the various language files. Probably cumbersome, but might be less work than restructuring how the core translation functions operate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants