-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: re-add territory replaced by 6.2 revamp #5116
Conversation
fix quisquous#5115, old territory id still needed for pre-6.2 game (cn/ko)
Instead of duplicating the trigger files for the old zoneIds, you can just add them to the existing triggers as an array alongside the 6.2 IDs, along with a TODO to remove them once KO/CN catches up to 6.2. |
For why I want to duplicate those files is that the new version may have difference compare to old version, and when someone want to update it, it will become a pain for compatible with old version, so instead putting 6.1 and 6.2 zone id into the same trigger files, I think duplicating is the more comfortable solution. |
I think there are already differences. I updated the Sohm Al headmarkers in 5e84ec8 and so probably that needs to be reverted for the 6.1 version. Do you want to undo that in the 6.1 files? Agreed that if the files are the same we don't need to duplicate, but I suspect that all of these have changes that nobody's updated the files for, so it's probably best to duplicate up front and we'll just remove the duplicates when everything has updated. EDIT: Sorry, that's maybe ambiguously worded. I'm saying I agree that duplicating files is the right approach, since there are likely changes across game versions even if the files aren't updated yet. |
Thanks for reminding! I just check those triggers and seems the Sohm AI headmarker is needed to update even after reverted (Due to the 6.0 headmarker changes? I don't know), so I update it and now this PR should be ready for review again. |
Thank you for this! |
fix #5115, old territory id still needed for pre-6.2 game (cn/ko)